Skip to content

🍒 [lldb] Add build option to specify the libxml 2 version (llvm#142183) #10774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: stable/20240723
Choose a base branch
from
Open

🍒 [lldb] Add build option to specify the libxml 2 version (llvm#142183) #10774

wants to merge 1 commit into from
+6 −1

Conversation

Steelskin
Copy link

The Swift Windows toolchain uses its own static build of libxml 2, which is more recent than 2.8, resulting in the provided libxml 2 to be rejected. This change allows to specify a custom version for libxml 2, while defaulting to 2.8.

(cherry-picked from commit llvm/llvm-project@a080c74)

@Steelskin Steelskin requested a review from a team as a code owner May 30, 2025 23:32
@JDevlieghere
Copy link

@swift-ci test

@compnerd
Copy link
Member 

18:05:42  Traceback (most recent call last):
18:05:42    File "C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\line-directive", line 738, in <module>
18:05:42      run()
18:05:42    File "C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\line-directive", line 689, in run
18:05:42      command = subprocess.Popen(
18:05:42    File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\subprocess.py", line 951, in __init__
18:05:42      self._execute_child(args, executable, preexec_fn, close_fds,
18:05:42    File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\subprocess.py", line 1420, in _execute_child
18:05:42      hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
18:05:42  FileNotFoundError: [WinError 206] The filename or extension is too long
18:05:42  Batch file failed at line 6 with errorcode 1

@compnerd
Copy link
Member

@swift-ci please test Windows platform

@Steelskin
🍒 [lldb] Add build option to specify the libxml 2 version (llvm#142183)
0dbbcb7 
The Swift Windows toolchain uses its own static build of libxml 2, which
is more recent than 2.8, resulting in the provided libxml 2 to be
rejected. This change allows to specify a custom version for libxml 2,
while defaulting to 2.8.

(cherry-picked from commit llvm/llvm-project@a080c74)
@Steelskin Steelskin force-pushed the fabrice/cp-option-lldb-libxml2-version branch from 00f7208 to 0dbbcb7 Compare June 3, 2025 21:11
@compnerd
Copy link
Member

compnerd commented Jun 3, 2025

@swift-ci please test

@compnerd
Copy link
Member

compnerd commented Jun 3, 2025

Please test with following PRs:
swiftlang/swift#81961

@swift-ci please test Windows platform

@Steelskin
Copy link
Author

The line-directive issue should be fixed with swiftlang/swift#81996

@compnerd
Copy link
Member

compnerd commented Jun 5, 2025

@swift-ci please test macOS platform

@compnerd
Copy link
Member

compnerd commented Jun 5, 2025

@swift-ci please test Windows platform

1 similar comment
@compnerd
Copy link
Member

compnerd commented Jun 5, 2025

@swift-ci please test Windows platform

@compnerd
Copy link
Member

compnerd commented Jun 5, 2025

@swift-ci please test macOS platform

@compnerd
Copy link
Member

@swift-ci please test Windows platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JDevlieghere JDevlieghere JDevlieghere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Steelskin @JDevlieghere @compnerd